Lian Cheng wrote:
Hi everyone,
Has anybody noticed that the Spring version of chat example breaks? The
trouble maker is
mina-examples/src/main/resources/org/apache/mina/example/chat/serverContext.xml,
in which there is still classes already removed from trunk long ago, such
as:
- org.apache.mina.integration.spring.ssl.KeyStoreFactoryBean
- org.apache.mina.integration.spring.ssl.BogusTrustManagerFactory
- org.apache.mina.integration.spring.ssl.SslContextFactoryBean
- org.apache.mina.integration.spring.DefaultIoFilterChainBuilderFactoryBean
And, even worse, there seems no substitutions in current trunk code base. I
think it is because Spring assembles objects by reflection and compile time
checking is obviously not effective, and thus Maven cannot report any error
while packaging. It seems more integration test code should be added to
prevent similar runtime errors.
Also, I suggest developers have the Spring IDE at hand and add Spring
project nature to the mina-example project, so that Spring IDE can detect
and report similar errors.
Cheers
Cheng
You're right, the serverContext.xml file has to be updated. The three
first missing classes now live in org.apache.mina.filter.ssl. The last
one should be replaced with
org.apache.mina.common.DefaultIoFilterChainBuilder directly because it
now has the setFilters() method.
I will take care of this this weekend.
Thanks for letting us know!
/Niklas
