On Tue, Feb 26, 2008 at 3:50 PM, Dave Roberts <[EMAIL PROTECTED]> wrote: > So, will all LOG writes (e.g. PASS.java:215) be replaced with this > new logging functionality?
There should be no need for that. The MINA MdcInjectionFilter sets some things for us (handlerClass, remoteAddress, localAddress, remoteIp, remotePort, localIp, localPort) and we provide some additional FTP specific items, current the user name (USER line 74). We could set additional values if we would like to, maybe indicating the session status like what file is currently being downloaded. > If so, can we also expose the FtpIoSession to things like the > FileSystemManager, FileSystemView and FileSystemObject, as well as > the Ftplet implementations, such that other implementations can make > use of the logging as well. That would be completely transparent, no changes required. Just add the normal log statements where needed and the MDC context will be handled for them. > In terms of the information stored in the MDC attributes, I think > we'd benefit from something unique, like the client host _and_ > client port, or a hex version of the connection timestamp. You mean a session identifier? /niklas
