On Thu, Mar 20, 2008 at 9:48 AM, Emmanuel Lecharny <[EMAIL PROTECTED]> wrote:
> Julien Vermillard wrote: > > On Wed, 19 Mar 2008 23:53:03 +0100 > > Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > > > > > >> Frédéric Brégier wrote: > >> > >>> Those numbers are useful in production... (at least for my case) > >>> I know, it's only about statistics but some people want them... > >>> > >>> If I follow your idea, what will return IoService.getStatistics() ? > >>> > >>> > >> I guess that Peter meant something like : getStatistics( > >> IoSession.GET_MANAGED_SESSION_COUNT ), etc. > >> > >> Then you have your stats, _and_ you don't clutter the API with dozens > >> of additional methods. > >> > >> Otherwise, what about using JMX for such stats ? > >> > >> > > > > Hi, > > > > heh I don't think JMX should be mandatory for having access to stats. > > And you talk about bloat ? ;) > > > Well, JMX is pretty transversal... We can't say it's a bloat :) > > Anyway, it was just a proposal :) > JMX is just a way to access this information which still needs to be stored somewhere in some statistics object. JMX won't instantly give us the statistics variables. I like Peter's idea of having a statistics object to contain instance/accumulated stats. BTW I don't think we need to create this object everytime the stats are queried. The object can be created once and reused. Hence getStatistics() will always return the same object instance, and MINA will just update values in it. Alex
