On Jun 25, 2008, at 12:53 AM, W.B. Garvelink wrote:
I have some concern though that we're just trading the massive IoService APIfor a massive statistics API. It's an improvement!, but please consider splittingoff the statistics methods into *two* statistics objects: one that deals withthroughput and message size, and one that deals with idle times.Furthermore: I think the statistics objects returned from the IoService shouldbe defined as interfaces, not classes (this is just me stating the obvious, givenhow interfaces are used in the rest of MINA). The same interface can then bedeployed into the JMX MBeanServer, and the method implementations canremain where they are inside AbstractIoService, which just implements the interfaces and returns its this-pointer from the getStatistics() methods.
i think that's a very reasonable improvement. care to work up a patch? :)
-pete -- [EMAIL PROTECTED] - http://fotap.org/~osi
smime.p7s
Description: S/MIME cryptographic signature
