On Jun 25, 2008, at 12:53 AM, W.B. Garvelink wrote:
I have some concern though that we're just trading the massive IoService API
for a massive statistics API. It's an improvement!, but please
consider splitting
off the statistics methods into *two* statistics objects: one that deals with
throughput and message size, and one that deals with idle times.

Furthermore: I think the statistics objects returned from the IoService should
be defined as interfaces, not classes (this is just me stating the
obvious, given
how interfaces are used in the rest of MINA). The same interface can then be
deployed into the JMX MBeanServer, and the method implementations can
remain where they are inside AbstractIoService, which just implements the interfaces and returns its this-pointer from the getStatistics() methods.

i think that's a very reasonable improvement. care to work up a patch? :)

-pete

--
[EMAIL PROTECTED] - http://fotap.org/~osi




Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to