[
https://issues.apache.org/jira/browse/DIRMINA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614331#action_12614331
]
Emmanuel Lecharny commented on DIRMINA-608:
-------------------------------------------
Patch applied.
One more thing would be valuabe : atm, the getStatistics() method return
'this', which means all the methods are included into the AbstractIoService
class. It would be much more preferable that the statistics were implemented
into a separated class, so that the getStatistics() method returns a reference
to this class. The AbstractIoService would then be much more light.
That also means we won't have to implement IoServiceStatistics in
AbstractIoService. A simpler IoStatistics interface with a getStatistics()
method would be enough.
wdyt ?
> Move stats out of the IoService API
> -----------------------------------
>
> Key: DIRMINA-608
> URL: https://issues.apache.org/jira/browse/DIRMINA-608
> Project: MINA
> Issue Type: Improvement
> Affects Versions: 2.0.0-M2
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 2.0.0-M3
>
> Attachments: IoServiceStatistics.patch
>
>
> The statictic informations contained into the IoService API could be put in
> some specific class, and made available through a call to a dedicated getter :
> IoServiceStatistics getStatistics()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
