[
https://issues.apache.org/jira/browse/FTPSERVER-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633475#action_12633475
]
Niklas Gustavsson commented on FTPSERVER-181:
---------------------------------------------
Thanks!
This page describes how to contribute, note that it is important that if you
provide a patch that you check the radio button to allow your patch for
inclusion in ASF software.
http://apache.org/dev/contributors.html#patches
We do not normally put contributor names in source files, but I'll happily list
you as a contributor in our POM (I'll make sure to not include your email
address). Could you please provide the above improvment as patch and add it as
an attachment to this issue and I'll commit it.
Again, thanks for your work!
> The UserManager#authenticate() method lacks of documentation
> ------------------------------------------------------------
>
> Key: FTPSERVER-181
> URL: https://issues.apache.org/jira/browse/FTPSERVER-181
> Project: FtpServer
> Issue Type: Bug
> Components: Ftplets
> Affects Versions: 1.0-M3
> Reporter: Andrea Francia
> Fix For: 1.0-M4
>
>
> The UserManager interface documentation should be a form of contract between
> the implementor and the user of the interface.
> After reading the documentation the implementor still has these question:
> - when I should throw a AuthenticationFailedException?
> - when I should return a null as a result?
> - if the object receive two subsequent calls withe the same arguments the
> objects returned should be the same (same reference), only equals, or they
> can be different?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
