2008/10/31 Niklas Gustavsson <[EMAIL PROTECTED]> > On Thu, Oct 30, 2008 at 10:13 PM, David Latorre <[EMAIL PROTECTED]> wrote: > > To my mind, in most cases when we return SKIP we would also want to skip > the > > afterCommand( e.g., I check if the data channel is secured in > > beforeCommand and if it is not, I write an appropiate response and > return > > SKIP . Afterwards, onUploadEnd() could try to copy the file to another > > location, update the database to record the event of the arrival ... In > this > > case, I don't want afterCommand to be called. > > You may argue that there're cases in which we still want that the > > afterCommand be called. > > I can't actually think of such a case. Could you give an example? if > not, I think we should change the behavior so that afterCommand is not > called if SKIP is returned. I believe the current behavior is there > due to me not thinking properly :-) >
The only reason for this I can think is to do some cleanup - but you're right it seems not very likely if you skipped the whole command. So, if everone agrees (yeah maybe we are not that many - yet x) i it should be ok to just skip the whole thing when SKIP is returned. david.
