[
https://issues.apache.org/jira/browse/DIRMINA-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646583#action_12646583
]
Emmanuel Lecharny commented on DIRMINA-635:
-------------------------------------------
The preAdd method takes a IoFilterChain as a first argument, which has a
getSession() method, so there is no need to pass a IoSession.
It will then be easy to modify the preAdd method to initialize the encoder and
decoder there, instead of doing so in the sessionCreated() method.
Also we have to do it in both case, as the preAdd method is not called when the
filter is added in the chain outside of the session.
> The IoFilter.preAdd method should take an IoSession argument
> ------------------------------------------------------------
>
> Key: DIRMINA-635
> URL: https://issues.apache.org/jira/browse/DIRMINA-635
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M3
> Reporter: Emmanuel Lecharny
>
> When injected an ProtocolCodecFilter in a chain when a session is already
> created, the encoder and decoder are never injected into the session's
> attribute, leading to NPE.
> This could be fixed if we create those objects during the preAdd() phase, but
> we need to pass the session to this preAdd method. Anyway, it makes sense, as
> we may want to update some session's attribute during the addition, just in
> case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
