[
https://issues.apache.org/jira/browse/FTPSERVER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693599#action_12693599
]
Niklas Gustavsson commented on FTPSERVER-253:
---------------------------------------------
I don't see that we can do the change in the Command interface as that would
break our API and force a FtpServer 2.0, which we're not really ready for :-)
> I'm leaning towards the second approach of creating a Result object which
> holds all the information about the execution result, which includes the
> FtpReply we sent.
> We cannot use the described soultion #1 (extending DefaultFtpReply) as is
> because we have a subclass of DefaultFtpReply which is the LocalizedFtpReply.
> So, if we want to go with solution #1 we have to extend the new Reply classes
> such
> as RenameFtpReply from LocalizedFtpReply or get rid of the LocalizedFtpReply
> and make the DefaultFtpReply support both English and Localized messages.
I still prefer using FtpReply for this. The inheritance hierarchy would all be
in the interfaces (extensions from FtpReply) and thus we could implement them
all in LocalizedFtpReply if we would like to (not saying it's a good idea :-).
/niklas
> Enhance the Ftplet.afterCommand to provide more information about the result
> of command execution
> -------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-253
> URL: https://issues.apache.org/jira/browse/FTPSERVER-253
> Project: FtpServer
> Issue Type: New Feature
> Components: Core, Ftplets
> Reporter: Sai Pullabhotla
> Fix For: 1.1
>
>
> It would be nice to enhance the afterCommand method in the Ftplet to provide
> additional details about the result of command execution. Currently the
> afterCommand method of an Ftplet is called back with the following parameters
> -
> FtpSession, FtpRequest and FtpReply. The FtpReply parameter contains only the
> reply code and the reply string that was sent. The Ftplets may want to know a
> little more information on what exactly happened to the command that was
> executed. For example, the afterCommand for RNTO command might want to know
> the from file, the to file and if the command was successful or not.
> More information on this can be found at
> http://www.mail-archive.com/[email protected]/msg00512.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
