Hi guys,
recently I saw some commits on MINA where some code has been refactored
(like lines were limited to 80 caracters, stuff like that).
I don't think it's a bad thing to do code refactoring, but the problem
is that when it's mixed with some code addition, it buries the fixes
into a lot of refactoring, and it's difficult for reviewers to check the
fixes.
My personal guess is that those who are committing such code are using
some specific options on their favorite IDE, leading to such injection
of code.
It's not only about line splitting, it can be addition of windows style
EOL, or even tabs. I'm not free from such injections, I must admit.
There is a Eclipse formating file for those who are using Eclipse, that
must be used in order to avoid such automatic refactoring :
http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention
If you are using another IDE, it could be cool to create the same kind
of file.
Last, not least, if you think the file need to be refactored, feel free
to do so, but *please*, do that in a separate commit : first refactor
the code, commit it and then fix the code and commit again.
Many thanks !
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
,
