It seems we should do the work and configure the pseudo terminal in the right way given the received parameters from the client. Unfortunately, we don't do that as you've seen.
I think we should define a terminal abstraction that would be given to the ShellFactory when creating the shell, but I'm not sure yet what needs to be done. Ideally, we should be able to integrate with the OS when launching a real shell. On Mon, Aug 17, 2009 at 13:51, Frank van der Kleij <kl...@hotmail.com>wrote: > > Thanks for the feedback. > > It's not that I wouldn't want to work on it, but unfortunately I don't have > the time to dig > in the SSH specifics. I am trying to abstract from it as much as possible > and see it as a > transport layer. I am working on it after hours only and got my hands full > with the rest. > > In ChannelSession only ONCLR is used (in handleShell), do you think the > echoing should > be managed there or is it a shell responsibility? > > > > > Date: Mon, 17 Aug 2009 02:09:04 +0200 > > Subject: Re: [sshd] clients and echo > > From: gno...@gmail.com > > To: dev@mina.apache.org > > > > The echo stuff amongst other things is sent using the pty-req command > from > > the ssh client to the server. > > The problem is that those parameters can't be modified atm, so we need to > > enhance the client api to allow overriding those parameters. > > You can make a try by changing the client code and sending 0 for ECHO, > > ECHOE, ECHO_K, ECHO_NL, NOFLSH and see if it behaves better. > > > > The other problem is that the server side supports this command and store > > the value of the different configuration bits (see > ChannelSession#ptyModes), > > but has no way to inform the shell that those values have changed. > > > > I think we should raise jira about these issues and fix them if possible. > > Wanna raise the jiras and eventually work on a patch ? > > > > On Sun, Aug 16, 2009 at 21:07, Frank van der Kleij <kl...@hotmail.com > >wrote: > > > > > > > > I am trying to roll my own sshd based server but I am having some > issues > > > with the different clients and echoing what comes in. > > > > > > It seems like most clients send each character to the server and expect > the > > > server to echo it. The term attribute is set to 'xterm <something> ' > for > > > PuTTY and *nix based ssh clients; cygwin sets 'cygwin'. > > > > > > The java sshd client sets 'dummy' for term. It does not send each > > > character, but waits until the user presses Enter and thus does not > need the > > > server to echo. Echoing would just repeat what the user entered before > the > > > result is shown. > > > > > > I am currently activating echo on the server when the term attribute > starts > > > with xterm or cygwin, but this does not seem a very good approach. God > knows > > > which other clients could connect. > > > > > > Is there any way to determine in a clean way whether the sshd server > should > > > echo what comes in? Should it always echo and is the sshd client wrong > here? > > > > > > > > > > > > _________________________________________________________________ > > > Express yourself instantly with MSN Messenger! Download today it's > FREE! > > > http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/ > > > > > > > > > > > -- > > Cheers, > > Guillaume Nodet > > ------------------------ > > Blog: http://gnodet.blogspot.com/ > > ------------------------ > > Open Source SOA > > http://fusesource.com > > _________________________________________________________________ > Express yourself instantly with MSN Messenger! Download today it's FREE! > http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/ > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
