Guillaume Nodet <gno...@gmail.com> wrote: > I wonder if we should add back the createBuffer method with a single > argument that would call createBuffer(cmd, 0) for readability...
I thought about doing that when I wrote the change... but since Session is an interface I wasn't too thrilled about exposing two different createBuffer methods in it. Its easy enough for me to change though, I can back out most of the patch and add the createBuffer(int) signature if that's what you'd prefer. > On Tue, Dec 15, 2009 at 04:56, <spea...@apache.org> wrote: > > Author: spearce > > Date: Tue Dec 15 03:56:32 2009 > > New Revision: 890631 ... > > Unfortunately most uses of createBuffer don't care about the size > > of the buffer, as they are one-shot requests which are often within > > the default size of 512 bytes. Pass in 0 for these and allow them > > to use the default 512 byte size.