I'm reviewing the changes in this release, and have a couple of
concerns on the fix for FTPSERVER-347.
1. I think the RFC says to indent only if intermediate lines begin
with 3 digits. Below is the excerpt from the RFC:
"If an intermediary line begins with a 3-digit number, the Server
must pad the front to avoid confusion."
The fix pads all lines that starts with a digit. Not sure if it is a big deal.
2. The fix uses Character.isDigit() to check if the first character in
any line is a digit. The isDigit method returns true for several other
characters other than the Latin 0 through 9. We should probably just
compare the decimal value of the character like ch >= 48 and ch <= 57?
3. The fix applies padding to the first line as well as the last line
if they begin with a digit. Instead, it should pad intermediate lines
only. Again, this is not a big deal.
Regards,
Sai Pullabhotla
On Sun, Mar 7, 2010 at 7:48 AM, Niklas Gustavsson <nik...@protocol7.com> wrote:
> Hey,
>
> Our alert users has reported yet some more bugs and we have fixed
> them. Time for another release.
>
> You can find the distributions and Maven artifacts here:
> http://people.apache.org/~ngn/ftpserver/1.0.4/
>
> These files was built from the following code:
> https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.4
>
> Changelog:
> https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314283
>
> [ ]: +1, Release FtpServer 1.0.4
> [ ]: 0, Abstain
> [ ]: -1, Don't release FtpServer 1.0.4
>
> /niklas
>
