Hi, Now that 2.0. is coming so close, I tried to get a cleaner fix for the MdcInjectionFilterTest that used to be failing. Sorry that I didn't get to it sooner.
The problem lies not so much in that test-case. IMO, the problem is basically that since revision=900163 [1] we no longer have an API to block until an AbstractIoService is completely disposed. I am afraid that we have a lot of test-cases that leave threads behind, when finished. I have just added an overloaded dispose method : public final void dispose(boolean awaitTermination) that resurrects the previous behaviour. To be safe I didn't change the default behaviour : dispose() = dispose(false) = do not wait for termination. Out of curiosity, I ran all tests with dispose() = dispose(true) and they all passed. I also added the attachment for DIRMINA-755 as a test-case. Note that you should run the main-method instead of the test-case : running the test-case from my IDE (Intellij IDEA) just resulted in "All Tests Passed" instead of blocking until all threads finish. The weird thing is that the behaviour is unpredictable. When you run the test several times, most often the call to dispose is done by NioProcessor-6, but sometimes it's done by the "main" thread !? (it's always run by main when you uncomment the call to Thread.sleep) The following questions remain : * should we support calling connector.dispose from the closeFuture callback ? I don't think so. * If we don't support it, should we try to detect it, and log a warning about is ? I don't think so. Trying to detect if people are shooting themselves in the foot is not easy in this case (or at least not elegant). Maarten [1] http://svn.apache.org/viewvc?view=revision&revision=900163 [2] https://issues.apache.org/jira/browse/DIRMINA-755 On Fri, Sep 10, 2010 at 4:13 PM, Emmanuel Lecharny <[email protected]>wrote: > Hi guys, > > today we worked on a vast cleanup on MINA build (pom.xml and distribution > module). > > I think we are ready for a release, but I have to run for the week-end, and > I can't create the branch. > > The distribution module is now completed and is creating the needed sources > package, so it's just a matter of creating the branch and launch the vote. > > If someone want to do that this week-end, that would be fine. Otherwise, > i'll do it on monday. > > Have fun ! > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com > >
