[
https://issues.apache.org/jira/browse/SSHD-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545972#comment-13545972
]
Guillaume Nodet commented on SSHD-196:
--------------------------------------
A few comments on the patch:
* there are auto-generated code with TODO comments which should be removed
* please use 4 spaces instead of tabs
* one test can not even compile because of the interface change
* no unit test to check the new stuff
Also, one thing I don't really understand yet is the use of the
PasswordChangeException. It seems to have to be thrown by the
PasswordAuthenticator when authenticating a user, so I suppose it means the
underlying authentication system wants the user to change its password, but I
don't see that information being sent back to the client. Did I miss something
? Also, a comment on the PasswordAuthenticator#auth method explaining the
purpose of throwing this exception very briefly would be helpful.
> Allow passwords to be changed when the server is forcing a password change
> --------------------------------------------------------------------------
>
> Key: SSHD-196
> URL: https://issues.apache.org/jira/browse/SSHD-196
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Paul Szczesniak
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: patch.txt
>
>
> For security purposes, passwords often expire after a fixed amount of time.
> This patch allows the user to change their password when forced by the server.
> Obviously, it should be reviewed because it makes key changes to the
> ServerSession.userAuth method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
