On Sun, Dec 22, 2013 at 11:53 AM, Emmanuel Lécharny <[email protected]>wrote:
> Le 12/22/13 6:43 PM, Kenny Root a écrit : > > I just made a patch to MINA SSHD to support RFC 5656 (ECDSA and ECDH). I > > would like to contribute this back to the code base, but I'm not sure of > > the exact way in which it should be submitted. > > > > Note that this patch has some requirements that should be noted: > > 1. The required classes such as ECParameterSpec is only available in Java > > 1.5 or newer. > > That's not an issue. We don't support 1.4 anymore. > > > 2. Sun/Oracle's JRE didn't have support for EC on all platforms until Java > > 7 (I think Solaris was earlier) > > 3. OpenJDK doesn't have support built-in until Java 8 > > > > One mitigation for those JDK problems is that Bouncycastle has worked > with > > EC for many versions. > > can we depend on ECParameterSpec class from BouncyCastle, and not depend > on a JVM version ? BouncyCastle registers by default JCE support for all EC algorithms needed, so this is reasonable. Any preference on reviewing this patch? I was going to fork on Github and submit my patch to my fork so it could be commented on.
