[ 
https://issues.apache.org/jira/browse/DIRMINA-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emmanuel Lecharny updated DIRMINA-956:
--------------------------------------
    Description: 
I found following code in AbstractHttpLogicHandler:

{code}
protected HttpProxyResponse decodeResponse(final String response) throws 
Exception {
...
        // Status code is 3 digits
        if (statusLine[1].matches("^\\d\\d\\d")) {
            throw new Exception("Invalid response code (" + statusLine[1] + "). 
Response: " + response);
        }
...
}
{code}

Is there 
{code}
statusLine[1].matches("^\\d\\d\\d")
{code} 
should be 
{code}
!statusLine[1].matches("^\\d\\d\\d")
{code}
?

  was:
I found following code in AbstractHttpLogicHandler:

{code}
protected HttpProxyResponse decodeResponse(final String response) throws 
Exception {
...
        // Status code is 3 digits
        if (statusLine[1].matches("^\\d\\d\\d")) {
            throw new Exception("Invalid response code (" + statusLine[1] + "). 
Response: " + response);
        }
...
}
{code}

Is there "statusLine[1].matches("^\\d\\d\\d")" should be 
"!statusLine[1].matches("^\\d\\d\\d")"?


> Status code match bug in AbstractHttpLogicHandler 
> --------------------------------------------------
>
>                 Key: DIRMINA-956
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-956
>             Project: MINA
>          Issue Type: Bug
>    Affects Versions: 2.0.7
>            Reporter: Kim
>
> I found following code in AbstractHttpLogicHandler:
> {code}
> protected HttpProxyResponse decodeResponse(final String response) throws 
> Exception {
> ...
>         // Status code is 3 digits
>         if (statusLine[1].matches("^\\d\\d\\d")) {
>             throw new Exception("Invalid response code (" + statusLine[1] + 
> "). Response: " + response);
>         }
> ...
> }
> {code}
> Is there 
> {code}
> statusLine[1].matches("^\\d\\d\\d")
> {code} 
> should be 
> {code}
> !statusLine[1].matches("^\\d\\d\\d")
> {code}
> ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to