Le Fri Nov 07 2014 at 1:42:43 AM, Emmanuel Lécharny <elecha...@gmail.com> a écrit :
> Le 06/11/14 23:15, Jeff MAURY a écrit : > > Hello, > > > > upon Emmanuel's request, I reviewed the fix for DIRMINA-994 > > (commit f1972fc3de8c4074ff7b60f8c557d3c53013e30b). Here are my remarks: > > > > - the Future framework in MINA2 is not linked in any form to JDK's > > Future, is there any reason for that ? I've seen that IOFuture in > MINA3 > > extends Future > > Java Future were introduced in hava 5. MINA was created with Java 1.4 > compatibility as a target. > Can't accpet it, as MINA2 code uses generics. > > > - Regarding MINA3, I suggest that IOFuture's implementation should > > benefit from helper class AbstractQueuedSynchronizer ( > > http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ > concurrent/locks/AbstractQueuedSynchronizer.html). > > As MINA3 Future framework is linked to the JDK Future framework, the > change > > should be quite small and simple. I will open a JIRA for that > > Ok. > > Thanks ! > >
