[
https://issues.apache.org/jira/browse/SSHD-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15619677#comment-15619677
]
ASF GitHub Bot commented on SSHD-706:
-------------------------------------
GitHub user davido opened a pull request:
https://github.com/apache/mina-sshd/pull/27
[SSHD-706] AbstractSession#checkForTimeouts: Avoid eager log4j invoca…
…tions
Without Logger.isDebugEnabled() guard, the log message was always
constructed even though the log level was less than debug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davido/mina-sshd patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 797fe12f3a1bb982fb5a1047cee30cfd1a7bef81
Author: David Ostrovsky <[email protected]>
Date: 2016-10-30T10:00:38Z
[SSHD-706] AbstractSession#checkForTimeouts: Avoid eager log4j invocations
Without Logger.isDebugEnabled() guard, the log message was always
constructed even though the log level was less than debug.
----
> Error: GC overhead limit exceeded after upgrade to 1.3.0
> --------------------------------------------------------
>
> Key: SSHD-706
> URL: https://issues.apache.org/jira/browse/SSHD-706
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 1.3.0
> Environment: Gerrit Code Review
> Linux, 8 core, 32 GB RAM.
> Reporter: David Ostrovsky
> Attachments: stack_dumps_sshd_706.zip
>
>
> Since upgrade to SSHD 1.3.0 and Mina 2.0.15 junit tests are failing with:
> {code}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> {code}
> All is fine on SSHD 1.2.0 and Mina 2.0.10.
> CL is here: 1 and CI log is here: 2.
> * 1. https://gerrit-review.googlesource.com/87435
> * 2.
> https://gerrit-ci.gerritforge.com/job/Gerrit-verifier-default/14968/consoleText
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
