[
https://issues.apache.org/jira/browse/SSHD-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet resolved SSHD-739.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5.0
https://git1-us-west.apache.org/repos/asf?p=mina-sshd.git;a=commitdiff;h=87b87f7dad2f28b94e616688e4e5bb47dc75f459
> A call to resolvePropertyValue can be very inefficient
> ------------------------------------------------------
>
> Key: SSHD-739
> URL: https://issues.apache.org/jira/browse/SSHD-739
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: 1.5.0
>
>
> Each time a property is retrieved, all system properties names are iterated.
> This is because {{PropertyResolverUtil#resolvePropertyValue}} is calling
> {{GenericUtils.isEmpty(props)}} on a {{SyspropsMapWrapper}}.
> This can be solved by using {{isNull(props)}} instead of {{isEmpty(props)}}
> as there's no need to check if the map is empty.
> In the same call, there's also a call to {{System.getProperty}} which seems
> to be redundant with the {{SyspropsMapWrapper}}. I think it should be
> removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
