[ 
https://issues.apache.org/jira/browse/SSHD-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083794#comment-16083794
 ] 

Goldstein Lyor commented on SSHD-700:
-------------------------------------

Hi Li,

I have posted my comments on the code you published in the pull request - in 
general, it is OK - except for a few minor issue that need to be fixed.

{quote}The UnixAgentFactory use Tomcat JNI, but I don't think it is 
necessary{quote}

The usage of Tomcat JNI is neither here nor there - the JNI provides some 
useful performance improvements. Although you make a good point - perhaps the 
choice between the {{LocalAgentFactory}} and the {{UnixAgentFactory}} should be 
made based on some user-defined property whose *default* value should be _Unix_ 
is {{OsUtils.isUnix()}} and _Local_ otherwise. This would mean that the user 
can override this default choice - e.g., if no JNI available/wanted

> SSHD does not suppot agent forwarding for XShell and XAgent
> -----------------------------------------------------------
>
>                 Key: SSHD-700
>                 URL: https://issues.apache.org/jira/browse/SSHD-700
>             Project: MINA SSHD
>          Issue Type: New Feature
>    Affects Versions: 1.2.0
>         Environment: Windows 10 and CentOS 7
> XShell 5.0
>            Reporter: Li Fangning
>            Priority: Minor
>         Attachments: block.png, debug.log, environment.png, log1.txt, 
> log2.txt, sshd-core.zip, SshdTest2.java, SshdTest3.java, stacktrace.png
>
>
> I use MINA SSHD for both server side and client side:
> SSH client  --> MINA SSHD Server - MINA SSHD Client --> Target Linux Server
> I use XShell (http://www.netsarang.com/) as SSH client, and use XAgent with 
> XShell for target server authentication (Public Key Access with Agent 
> Forwarding).
> I have tried PuTTY (with pagent), SecureCRT, and openssh client in linux, 
> they are all passed. But when I try XShell with XAgent, the agent forwarding 
> phase is failed.
> When I check the debug log and source code of MINA SSHD, I find that SSHD 
> only handle the "auth-agent-...@openssh.com" request type (in 
> org.apache.sshd.server.channel.ChannelSession#handleInternalRequest), which 
> is OK for PuTTY, SecureCRT and openssh client. But XShell send a 
> "auth-agent-req" request (without "@openssh.com"), so SSHD not handle the 
> request.
> I have try to change the source code, add "auth-agent-req" to the 
> "switch-case" in handleInternalRequest, but the authentication is blocked.
> I have attached my code, please help me solve the problem.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to