I know, I'm just trying to ask the questions to make things easier, specially for you as contributor ;-)
On 8 October 2017 at 17:37, Jonathan Valliere <jon.valli...@emoten.com> wrote: > Mina is in GIT. Someone made a clone in GitHub but I don't think that's > official. Pull Request might be a problem because the changes are right > now in a Detached Head and would have to create a branch of the tag. I'm > not sure how the Mina team is managing changes to older supported > versions. For that reason the diff might be easier, but I wanted to ask > anyway. > > On Sun, Oct 8, 2017 at 12:21 PM Guido Medina <oxyg...@gmail.com> wrote: > > > Isn't a Github setup for Apache Mina? wouldn't a PR be better then? > > > > On 8 October 2017 at 16:59, Jonathan Valliere <jon.valli...@emoten.com> > > wrote: > > > > > Emmanuel, > > > > > > Do you want me to attach a diff or something with the patch to the > JIRA? > > > > > > On Sun, Oct 8, 2017 at 5:41 AM, David Gibbs (JIRA) <j...@apache.org> > > > wrote: > > > > > > > > > > > [ https://issues.apache.org/jira/browse/DIRMINA-1057?page= > > > > com.atlassian.jira.plugin.system.issuetabpanels:comment- > > > > tabpanel&focusedCommentId=16195828#comment-16195828 ] > > > > > > > > David Gibbs edited comment on DIRMINA-1057 at 10/8/17 9:40 AM: > > > > --------------------------------------------------------------- > > > > > > > > Thank you Jonathan, I started investigating as it seems as if a > > > > QuickfFIX/J feature that relies on getScheduledMessages to detect > slow > > > > consumers did not behave as I expected. getScheduledBytes does seem > to > > > > work. I attached a link to an example that shows getScheduledMessages > > > > decrementing to large negative numbers. It's not writing files. > > > > > > > > Master shows the example with some QuickFIX/J classes > > > > https://github.com/david-gibbs-ig/mina-test-case/commits/master > > > > > > > > the branch here is mina only. > > > > https://github.com/david-gibbs-ig/mina-test-case/tree/mina-only-case > > > > > > > > > > > > > > > > was (Author: david-gibbs-ig): > > > > Thank you Jonathan, I started investigating as it seems as if a > > > > QuickfFIX/J that relies on getScheduledMessages to detect slow > > consumers > > > > did not behave as I expected. getScheduledBytes does seem to work. I > > > > attached a link to an example that shows getScheduledMessages > > > decrementing > > > > to large negative numbers. It's not writing files. > > > > > > > > Master shows the example with some QuickFIX/J classes > > > > https://github.com/david-gibbs-ig/mina-test-case/commits/master > > > > > > > > the branch here is mina only. > > > > https://github.com/david-gibbs-ig/mina-test-case/tree/mina-only-case > > > > > > > > > > > > > AbstractIoSession getScheduledWriteMessages always -negative? > > > > > ------------------------------------------------------------- > > > > > > > > > > Key: DIRMINA-1057 > > > > > URL: https://issues.apache.org/ > > > jira/browse/DIRMINA-1057 > > > > > Project: MINA > > > > > Issue Type: Bug > > > > > Components: Core > > > > > Affects Versions: 2.0.16 > > > > > Environment: I'm testing slow consumer backlog detection > and > > > > while getScheduledWriteBytes() correctly grows, > > getScheduledWriteMessages > > > > is always negative and does not increase. looking into code to see > why > > > but > > > > putting bug report here as well for tracking > > > > > Reporter: Andre Mermegas > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > This message was sent by Atlassian JIRA > > > > (v6.4.14#64029) > > > > > > > > > >
