[ 
https://issues.apache.org/jira/browse/SSHD-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322256#comment-16322256
 ] 

Goldstein Lyor edited comment on SSHD-793 at 1/11/18 2:12 PM:
--------------------------------------------------------------

Looks fine and I have no problem merging it - however, it is not clear how the 
leak occurs and why this code fixes it... can you elaborate on the scenario you 
think is causing the leak ?

Specifically, isn't this just another race condition ? What if the session is 
closed just after {{isClosing()}} is consulted ?
Thanks.


was (Author: lgoldstein):
Looks fine and I have no problem merging it - however, it is not clear how the 
leak occurs and why this code fixes it... can you elaborate on the scenario you 
think is causing the leak ?
Thanks.

> Continuously connecting to sshd server lead to memory leaks
> -----------------------------------------------------------
>
>                 Key: SSHD-793
>                 URL: https://issues.apache.org/jira/browse/SSHD-793
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>         Environment: Linux
>            Reporter: Li Fangning
>         Attachments: SshClientTest.java, SshdServerTest.java, changes.png
>
>
> Run the attachments [^SshdServerTest.java] and [^SshClientTest.java],  
> [^SshdServerTest.java]'s memory will continue to rise and lead to 
> {{OutOfMemory}} error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to