[ 
https://issues.apache.org/jira/browse/SSHD-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360346#comment-16360346
 ] 

Goldstein Lyor commented on SSHD-803:
-------------------------------------

[~fcava] I have read some more about the {{SSH_MSG_CHANNEL_EOF}} and to quote 
from [RFC 4254 - Section 5.3: Closing a 
channel|https://tools.ietf.org/html/rfc4254#section-5.3]
{quote}
When a party will no longer send more data to a channel, it SHOULD send 
SSH_MSG_CHANNEL_EOF

A party MAY send SSH_MSG_CHANNEL_CLOSE without having sent or received 
SSH_MSG_CHANNEL_EOF.
{quote}

In view of this, any code that expects {{SSH_MSG_CHANNEL_EOF}} before 
{{SSH_MSG_CHANNEL_CLOSE}} is non-compliant. While I am not against making the 
effort to send {{SSH_MSG_CHANNEL_EOF}} I do not want to make too many changes 
to the code if they involve "magical behavior" at various levels. I am fine 
with the changes to {{close(boolean immediately)}} that close the output 
stream. but do not feel comfortable (yet) with the {{Nio2Session}} change (see 
also my other comment regarding {{MinaSession}}-s).

> SSHD port forwarding. Missing SSH_MSG_CHANNEL_EOF
> -------------------------------------------------
>
>                 Key: SSHD-803
>                 URL: https://issues.apache.org/jira/browse/SSHD-803
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: Fulvio Cavarretta
>            Assignee: Goldstein Lyor
>            Priority: Major
>
> Using sshd as a server for local port forwarding, in case remote end closes 
> the connection gracefully while reading data, no SSH_MSG_CHANNEL_EOF message 
> is sent to SSH client, but only SSH_MSG_CHANNEL_CLOSE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to