[
https://issues.apache.org/jira/browse/SSHD-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433696#comment-16433696
]
ASF GitHub Bot commented on SSHD-812:
-------------------------------------
GitHub user lgoldstein opened a pull request:
https://github.com/apache/mina-sshd/pull/50
[SSHD-812] Made SftpSubsystem more thread-safe
Attached is my suggestion for the code changes:
* Split the `SftpSubsystem` functionality further to
`AbstractSftpSubsystemExecutor` by leaving the decision how to run it to the
concrete implementation.
* All "dangerous" access protected via _synchronized_ blocks
* Many _protected_ hooks for concrete classes - with concurrency in mind
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lgoldstein/mina-sshd SSHD-812
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit 01157272ac94739d0f980d2ddd3246f9f40b3270
Author: Goldstein Lyor <lyor@...>
Date: 2018-04-08T14:12:35Z
[SSHD-812] Made SftpSubsystem more thread-safe
----
> support asynchronous mode for sftp subsystem
> --------------------------------------------
>
> Key: SSHD-812
> URL: https://issues.apache.org/jira/browse/SSHD-812
> Project: MINA SSHD
> Issue Type: New Feature
> Affects Versions: 1.7.0
> Environment: java1.8, linux
> Reporter: Zhenliang Su
> Assignee: Goldstein Lyor
> Priority: Minor
> Labels: asynchronous, sftp
> Attachments: Main.java, doRead.png
>
>
> I used SSHD as a middleman between client and target sftp server.
> I found that, when filezilla client directly connect to the target sftp
> server, it transfers fast. When filezilla client connect to the middleman, it
> transfers slow.
> I analyzed the source code of
> org.apache.sshd.server.subsystem.sftp.SftpSubsystem#doRead, and I found it
> behaves like block mode, and client's other SSH_FXP_READ request blocked in
> the same thread.
>
> my middleman code:
> [^Main.java]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
