[ 
https://issues.apache.org/jira/browse/SSHD-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492533#comment-16492533
 ] 

Guillaume Nodet commented on SSHD-824:
--------------------------------------

I didn't want to spend too much time on writing a builder api to create 
collections, so I just used static blocks when the construction could not be 
done in a single statement.

https://github.com/apache/mina-sshd/commit/3c6bfab46d08e87b195d5d7f72cb940eeedda495

> Do not use anonymous inner classes to initialize collections
> ------------------------------------------------------------
>
>                 Key: SSHD-824
>                 URL: https://issues.apache.org/jira/browse/SSHD-824
>             Project: MINA SSHD
>          Issue Type: Task
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 2.0.0
>
>
> This is an abuse of the Object model.
> If needed, introduce a collection builder, especially for immutable 
> collections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to