[
https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556142#comment-16556142
]
Goldstein Lyor edited comment on SSHD-835 at 7/25/18 7:07 PM:
--------------------------------------------------------------
Seems reasonable - although after reviewing the code I would like to make a few
suggestions:
* Let's call the closeable {{ExecutorService}} something else so as not to
confuse it with {{java.util.ExecutorService}} - e.g. {{SshExecutorService}} or
{{CloseableExecutorService}}
* Looks like we have lost the ability to let users provide their own
{{ExecutorService}}-s - therefore
** Let's have {{NoCloseExecutor}} be a wrapper for a
{{java.util.ExecutorService}} and not just a closeable one
** Let's provide a {{ClosingExecutor}} to be a wrapper on
{{java.util.ExecutorService}} that delegates *all* calls to the wrapped
instance - including the shutdown - and shuts down on _close_ if not already
done so. Might not be the prevailing use-case (after all if the user wants the
executor to be shutdown then why provide their own) so I leave it up to you to
decide whether this is necessary (perhaps we can defer it until a request comes
up for it).
* Lets update the {{README.md}} file explaining these wrappers and their
intended use in the relevant section (I believe this issue is mentioned in the
documentation)
was (Author: lgoldstein):
Seems reasonable - although after reviewing the code I would like to make a few
suggestions:
* Let's call the closeable {{ExecutorService}} something else so as not to
confuse it with {{java.util.ExecutorService}} - e.g. {{SshExecutorService}} or
{{CloseableExecutorService}}
* Looks like we have lost the ability to let users provide their own
{{ExecutorService}}-s - therefore
** Let's have {{NoCloseExecutor}} be a wrapper for a
{{java.util.ExecutorService}} and not just a closeable one
** Let's provide a {{ClosingExecutor}} to be a wrapper on
{{java.util.ExecutorService}} that delegates *all* calls to the wrapped
instance - including the shutdown - and shuts down on _close_ if not already
done so. Might not be the prevailing use-case (after all if the user wants the
executor to be shutdown then why provide their own) so I leave it up to you to
decide whether this is necessary (perhaps we can defer it until a request comes
up for it).
> Introduce a Closeable ExecutorService
> -------------------------------------
>
> Key: SSHD-835
> URL: https://issues.apache.org/jira/browse/SSHD-835
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 2.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
