lgoldstein commented on issue #86: [bugfix] fix transfer large file bug(more than1GB) URL: https://github.com/apache/mina-sshd/pull/86#issuecomment-453806565 After reviewing the suggested fix there is another reason I am reluctant to merge it - it uses `compact` which potentially changes the `wpos`. This may prove an issue since some code remembers the `wpos` and then returns to it in order to re-write some data (e.g., when some buffer length is not known ahead of time). Therefore, unless you can point to an actual problem that occurs in an SSH session (even a malicious one) I don't think we can merge this code. I did add code that makes sure that `nextPowerOf2` does not yield negative values so it will protect the code from the issue you described that may yield an endless loop.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
