thefourtheye commented on a change in pull request #89: [SSHD-893] Fix SCP download with pattern issue in rooted filesystem URL: https://github.com/apache/mina-sshd/pull/89#discussion_r255807397
########## File path: sshd-common/src/main/java/org/apache/sshd/common/util/io/DirectoryScanner.java ########## @@ -115,49 +126,37 @@ * @author <a href="mailto:[email protected]";>Antoine Levy-Lambert</a> */ public class DirectoryScanner { - /** * The base directory to be scanned. */ - protected File basedir; + private Path basedir; /** * The patterns for the files to be included. */ - protected String[] includes; - - /** - * The files which matched at least one include and no excludes - * and were selected. - */ - protected List<String> filesIncluded; + private List<String> includePatterns; /** - * Whether or not the file system should be treated as a case sensitive - * one. + * Whether or not the file system should be treated as + * a case sensitive one. */ - protected boolean isCaseSensitive = true; + private boolean caseSensitive = OsUtils.isUNIX(); Review comment: I am trying to understand this better. You mean, overriding `caseSensitive` variable? This patch makes that `private`. Is that intentional? Also, `DirectoryScanner` is a standalone class, it's not implementing an interface or extending a class. So, if someone has to override this variable and use, they have to override `ScpFileOpener#getMatchingFilesToSend` as well with the modified `DirectoryScanner` implementation. Is my understanding correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
