[ https://issues.apache.org/jira/browse/SSHD-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797856#comment-16797856 ]
Goldstein Lyor commented on SSHD-907: ------------------------------------- {quote} Monitored for 25 hours. No issues so far. Thanks for the fix. {quote} Great - I will merge into the master {quote} Just noticed that there is one more issue where the username in the session is being cleared when authentication fails. {quote} Is there a reason *not* to clear the username if authentication fails ? After all, it means that this is not a valid user... {quote} Please Let me know if I need to create another ticket for that or this will suffice. {quote} I prefer having a separate issue - please describe in as much detail as you can the (mis) behaviour you are seeing as it can help focus on the problem and its fix faster. > Clearing user defined attributes in preclose is creating inconsistent > behaviour > ------------------------------------------------------------------------------- > > Key: SSHD-907 > URL: https://issues.apache.org/jira/browse/SSHD-907 > Project: MINA SSHD > Issue Type: Bug > Affects Versions: 2.3.0 > Reporter: Subramaniajeeva > Assignee: Goldstein Lyor > Priority: Major > Attachments: scp_nullified_attr.log > > > As a part of > [https://github.com/apache/mina-sshd/commit/f5d036ddd3de3521fb9f83253e30eab67bdbbcb3], > the user defined attributes are getting cleared from session. > This is creating inconsistent behaviour in `SftpEventListener` closed(). The > attributes are being vanished intermittently and the vanishing part is not > consistent. > > Is there any race condition which is not being handled properly? > -- This message was sent by Atlassian JIRA (v7.6.3#76005)