[ 
https://issues.apache.org/jira/browse/SSHD-909?focusedWorklogId=217034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217034
 ]

ASF GitHub Bot logged work on SSHD-909:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Mar/19 21:20
            Start Date: 21/Mar/19 21:20
    Worklog Time Spent: 10m 
      Work Description: bangnab commented on issue #98: [SSHD-909] SFTP 
versions extension handler ignores non-numerical ions when resolving the 
available ones
URL: https://github.com/apache/mina-sshd/pull/98#issuecomment-475407168
 
 
   @lgoldstein Ok I understand. It was just a suggestion.
   
   > BTW, I believe that in the version you mention you can extend 
DefaultSftpClient and override the negotiateVersion method. I agree it is not 
perfect, but it is a possible workaround.
   
   Thanks I hadn't thought of that!
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 217034)
    Time Spent: 1h  (was: 50m)

> Fix SFTP version re-negotiation support
> ---------------------------------------
>
>                 Key: SSHD-909
>                 URL: https://issues.apache.org/jira/browse/SSHD-909
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Goldstein Lyor
>            Assignee: Goldstein Lyor
>            Priority: Major
>             Fix For: 2.3.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> According to the 
> [standard|[https://tools.ietf.org/html/draft-ietf-secsh-filexfer-11#section-5.5]]
>  the versions are *strings* whereas the current code always treats them as 
> *integers*.
> {quote}
>       string "versions"
>        string comma-separated-versions
>    'comma-separated-versions' is a string of comma separated version
>    numbers.  Defined versions are: "2", "3", "4", "5", "6".  Any other
>    version advertised by the server must follow the DNS extensibility
>    naming convention outlined in [RFC4251].
>    For example: "2,3,6,[email protected]".
> {quote}
> Note: the same applies for the client's choice
> {quote}
>        string "version-select"
>        string version-from-list
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to