[
https://issues.apache.org/jira/browse/SSHD-929?focusedWorklogId=265795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265795
]
ASF GitHub Bot logged work on SSHD-929:
---------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/19 16:23
Start Date: 24/Jun/19 16:23
Worklog Time Spent: 10m
Work Description: lgoldstein commented on pull request #104: [SSHD-929]
Create separate listener for remove directory.
URL: https://github.com/apache/mina-sshd/pull/104#discussion_r296804536
##########
File path:
sshd-sftp/src/main/java/org/apache/sshd/server/subsystem/sftp/AbstractSftpSubsystemHelper.java
##########
@@ -1530,14 +1530,34 @@ protected void doRemoveDirectory(int id, String path,
LinkOption... options) thr
protected void doRemove(int id, Path p) throws IOException {
SftpEventListener listener = getSftpEventListenerProxy();
ServerSession session = getServerSession();
- listener.removing(session, p);
+ boolean isDirectory = Files.isDirectory(p);
Review comment:
According to the Javadoc:
>> false if the file does not exist, is not a directory, or it cannot be
determined if the file is a directory or not.
This means that if file does not exist to begin with we might declare it
a"regular" file and signal the incorrect callback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 265795)
Time Spent: 20m (was: 10m)
> Separate listener for deleting directory in SFTP
> ------------------------------------------------
>
> Key: SSHD-929
> URL: https://issues.apache.org/jira/browse/SSHD-929
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.3.0
> Reporter: Subramaniajeeva
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now listener for deletion of file and directory is common. This makes
> it difficult to find whether directory / file has been removed.
> The path passed to `removed` function in SftpEventListener will not tell if
> the deleted path was a directory or file. `Files.isDirectory(path)` will
> return false, as the derectory doesn't exist.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
