[
https://issues.apache.org/jira/browse/SSHD-961?focusedWorklogId=362497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362497
]
ASF GitHub Bot logged work on SSHD-961:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 10:16
Start Date: 23/Dec/19 10:16
Worklog Time Spent: 10m
Work Description: fcav1973 commented on pull request #110: [SSHD-961]
URL: https://github.com/apache/mina-sshd/pull/110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362497)
Remaining Estimate: 0h
Time Spent: 10m
> Not alla messages correctly handled in port forwarding mode
> -----------------------------------------------------------
>
> Key: SSHD-961
> URL: https://issues.apache.org/jira/browse/SSHD-961
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.3.1
> Reporter: Fulvio Cavarretta
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are some race conditions so that in port forwarding mode, not all
> messages are correctly managed during connections phase, leading to
> starvation.
>
> The problem is caused in
> {noformat}
> DefaultForwardingFilter.messageReceived{noformat}
> where
> {code:java}
> OpenFuture future = channel.getOpenFuture();
> Consumer<Throwable> errHandler = future.isOpened() ? null : e -> {
> try {
> exceptionCaught(session, e);
> } catch (Exception err) {
> log.warn("messageReceived({}) failed ({}) to signal
> {}[{}] on channel={}: {}",
> session, err.getClass().getSimpleName(),
> e.getClass().getSimpleName(),
> e.getMessage(), channel, err.getMessage());
> }
> };
> ClientChannelPendingMessagesQueue messagesQueue =
> channel.getPendingMessagesQueue();
> {code}
> should be
> {code:java}
> ClientChannelPendingMessagesQueue messagesQueue =
> channel.getPendingMessagesQueue();
>
> OpenFuture future = messagesQueue.getCompletedFuture();
> Consumer<Throwable> errHandler = future.isOpened() ? null : e -> {
> try {
> exceptionCaught(session, e);
> } catch (Exception err) {
> log.warn("messageReceived({}) failed ({}) to signal
> {}[{}] on channel={}: {}",
> session, err.getClass().getSimpleName(),
> e.getClass().getSimpleName(),
> e.getMessage(), channel, err.getMessage());
> }
> };
> {code}
> Because since the ClientChannelPendingMessagesQueue is a listener of the
> channel's OpenFuture, this latter can be in open state but the
> ClientChannelPendingMessagesQueue's completed feature still not, so that
> messages won't be correctly handled
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
