[ 
https://issues.apache.org/jira/browse/SSHD-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004038#comment-17004038
 ] 

Lyor Goldstein edited comment on SSHD-963 at 12/27/19 9:35 AM:
---------------------------------------------------------------

[~barry-gq]
{quote}but in fact they are separated
{quote}
- please examine the code *carefully* - they are separated, but each checks the 
existence of the *other* one - in other words, the code is making sure that 
*both* are set, and only then adds the relevant mask. According to [SFTP 
v3|https://tools.ietf.org/html/draft-ietf-secsh-filexfer-02#section-5] if the 
{{SSH_FILEXFER_ATTR_ACMODTIME}} is set then *both* times are available - and 
this is what the code ensures.

 

 
{quote}look forward to your updates in subsequent versions
{quote}
I don't foresee updates on this issue on subsequent releases since it feels 
like what you are asking is to violate the standard - which I am reluctant to 
do since it may break compatibility with existing clients.

 

 
{quote}I will try to modify it myself to temporarily fix this problem
{quote}
What I can suggest is the following: upgrade to the latest version and see if 
the problem persists - especially with +other clients+ such as WinSCP and 
OpenSSH. Perhaps FileZilla is trying to do something non-standard - it isn't 
the first time we've had issues open that turned out to be violations of the 
standard by various clients that were assuming that they were talking with a 
proprietary server of their own who was tolerating the non-standard behavior.

 

If the problem persists (even if it does only for FileZilla), try to debug the 
code sequence and try to figure out what *exactly* is causing problems - making 
sure especially that it is not something that only FileZilla does or some 
peculiar behavior of the O/S or the Java version you are using that somehow 
does not report both flags are existing. Once that is done, please update the 
issue and describe it. If indeed it is a mis-interpretation on our part we will 
gladly fix it. If not, I am willing to entertain adding a +special+ 
configuration property that can tell our client to "mis-behave" (default of 
course will be _false_).


was (Author: lgoldstein):
[~barry-gq] {quote}but in fact they are separated{quote} - please examine the 
code *carefully* - they are separated, but each checks the existence of the 
*other* one - in other words, the code is making sure that *both* are set, and 
only then adds the relevant mask. According to [SFTP 
v3|https://tools.ietf.org/html/draft-ietf-secsh-filexfer-02#section-5] if the 
{{SSH_FILEXFER_ATTR_ACMODTIME}} is set then *both* times are available - and 
this is what the code ensures.

{quote}look forward to your updates in subsequent versions{quote} I don't 
foresee updates on this issue on subsequent releases since it feels like what 
you are asking is to violate the standard - which I am reluctant to do since it 
may break compatibility with existing clients.

{quote}I will try to modify it myself to temporarily fix this problem{quote} 
What I can suggest is the following: upgrade to the latest version and see if 
the problem persists - especially with +other clients+ such as WinSCP and 
OpenSSH. Perhaps FileZilla is trying to do something non-standard - it isn't 
the first time we've had issues open that turned out to be violations of the 
standard by various clients that were assuming that they were talking with a 
proprietary server of their own who was tolerating the non-standard behavior.

If the problem persists (even if it does only for FileZilla), try to debug the 
code sequence and try to figure out what *exactly* is causing problems - making 
sure especially that it is not something that only FileZilla does. Once that is 
done, please update the issue and describe it. If indeed it is a 
mis-interpretation on our part we will gladly fix it. If not, I am willing to 
entertain adding a +special+ configuration property that can tell our client to 
"mis-behave" (default of course will be _false_).



> Uploading a file with filezilla,preserve timestamps of transferred files, but 
> setting fileAttributes failed
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SSHD-963
>                 URL: https://issues.apache.org/jira/browse/SSHD-963
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: barry-gq
>            Assignee: Lyor Goldstein
>            Priority: Blocker
>         Attachments: 1.png, 2.png
>
>
> *background:*
> I have a project to process some data with apache sshd-sftp
>  
> *Operation :*
> I use filezilla to upload a file and turn on the option to preserve the 
> timestamp of the transferred file,but modifytime is not set correctly
>  
> *java code description:*
> After uploading a file, the server code can receive the accesstime and 
> modifytime normally, but when the client processes version V3, there is only 
> one flags parameter, which makes it impossible to set modifytime 
> correctly.The two codes of the picture are: pciture 
> 1:AbstractSftpSubsystemHelper :: setFileAttributes, pciture 
> 2:AbstractSftpClient :: writeAttributes
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to