[
https://issues.apache.org/jira/browse/SSHD-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018149#comment-17018149
]
Roberto Deandrea commented on SSHD-964:
---------------------------------------
Gladly - we appreciate contributions from the community.
*OK*
The port forwarding code is pretty old and seems to work just fine till now -
it is the first time we encounter this complaint. As things stand right now
please note that we are in the process of releasing a new version so even if
this PR makes it into the code you will have to wait for the next release,
since it does not seem like a major issue.
*OK*
Can you also attach some reference to the RFC that specifies that these
messages must be sent for port forwarding (I will of course review the port
forwarding standard, but it would help to have some idea as to why you think
these messages are required).
*In RFC4254 The Secure Shell (SSHD) Connection Protocol I see the following :*
h3. [5.3|https://tools.ietf.org/html/rfc4254#section-5.3]. Closing a Channel
When a party will no longer send more data to a channel, it SHOULD
send SSH_MSG_CHANNEL_EOF.
byte SSH_MSG_CHANNEL_EOF
uint32 recipient channel
No explicit response is sent to this message. However, the
application may send EOF to whatever is at the other end of the
channel. Note that the channel remains open after this message, and
more data may still be sent in the other direction. This message
does not consume window space and can be sent even if no window space
is available.
........................................
> SSH_MSG_CHANNEL_EOF never sent or received for local and remote port
> forwarding
> -------------------------------------------------------------------------------
>
> Key: SSHD-964
> URL: https://issues.apache.org/jira/browse/SSHD-964
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.3.0, 2.3.1
> Reporter: Roberto Deandrea
> Assignee: Lyor Goldstein
> Priority: Major
>
> We found that the message SSH_MSG_CHANNEL_EOF is never sent or received for
> local and remote port forwarding connections.
> We found probably the issue and we changed the code locally in a couple of
> java classes to fix this issue.
> Let me know if we can commit our changes in a pull request (into a specific
> Apache SSHD branch) so that you can peer review the changes and decide if
> you can accept them...
>
> Kind Regards
> Roberto Deandrea
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
