[ 
https://issues.apache.org/jira/browse/SSHD-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021250#comment-17021250
 ] 

Lyor Goldstein edited comment on SSHD-964 at 1/22/20 5:07 PM:
--------------------------------------------------------------

I have looked at the code and as far as sending EOF when state is _Open_ or 
_Graceful_ instead of {{!isClosing()}} - this seems like an acceptable behavior 
change. As far as removing {{shutdownOutputStream()}} call - I still need to 
research this. I remember this was added for (at the time) a good reason...

I will prepare a candidate fix some time soon and let you know - so you can 
test it.


was (Author: lgoldstein):
I have looked at the code and as far as sending EOF when state is _Open_ or 
_Graceful_ instead of {{!isClosing()}} - this seems like an acceptable behavior 
change. As far as removing {{shutdownOutputStreamCall()}} - I still need to 
research this. I remember this was added for (at the time) a good reason...

I will prepare a candidate fix some time soon and let you know - so you can 
test it.

> SSH_MSG_CHANNEL_EOF never sent or received for local and remote port 
> forwarding
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-964
>                 URL: https://issues.apache.org/jira/browse/SSHD-964
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.3.0, 2.3.1
>            Reporter: Roberto Deandrea
>            Assignee: Lyor Goldstein
>            Priority: Major
>
> We found that the message SSH_MSG_CHANNEL_EOF is never sent or received for 
> local and remote port forwarding connections.
> We found probably the issue and we changed the code locally in a couple of 
> java classes to fix this issue.
> Let me know if we can commit our changes in a pull request (into a specific 
> Apache SSHD branch) so that you can peer review the changes  and decide if 
> you can accept them...
>  
> Kind Regards
> Roberto Deandrea
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to