[ 
https://issues.apache.org/jira/browse/SSHD-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023163#comment-17023163
 ] 

Lyor Goldstein commented on SSHD-964:
-------------------------------------

Thanks [~roberto.deandrea] for the valuable feedback.
{quote}
The rationale is that the SSH_MSG_CHANNEL_EOF message is not ackknoledged 
according to the standard.
{quote}
True, but the code in question does not seem to be acknowledging anything - it 
is sending an EOF independently. I am therefore inclined to remove it. Please 
let me know if you think there is a compelling reason why it should be left 
in....

{quote}
 think it's wrong shutdownOutputStream() when a client channel receives an EOF 
from the other side of the connection, because in this case the socket 
connection is always closed and I think it's not the right behavior. Maybe 
shutdownOutputStream() is to be performed later when the channel is being 
closed.
{quote}
I am inclined to agree with you - will make the necessary changes and let you 
know soon

> SSH_MSG_CHANNEL_EOF never sent or received for local and remote port 
> forwarding
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-964
>                 URL: https://issues.apache.org/jira/browse/SSHD-964
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.3.0, 2.3.1
>            Reporter: Roberto Deandrea
>            Assignee: Lyor Goldstein
>            Priority: Major
>
> We found that the message SSH_MSG_CHANNEL_EOF is never sent or received for 
> local and remote port forwarding connections.
> We found probably the issue and we changed the code locally in a couple of 
> java classes to fix this issue.
> Let me know if we can commit our changes in a pull request (into a specific 
> Apache SSHD branch) so that you can peer review the changes  and decide if 
> you can accept them...
>  
> Kind Regards
> Roberto Deandrea
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to