lgoldstein commented on issue #114: SSHD-968 interpret SSH_MSG_UNIMPLEMENTED response to a global request as its failure URL: https://github.com/apache/mina-sshd/pull/114#issuecomment-591989830 >> I thought you wanted a less invasive fix ;-) I did not mean less invasive as much as less aware of the purpose of the changes. It is less invasive as far as existing methods since it only introduces new ones. >> I don't really like the artificial split with the introduction of the preProcessEncodeBuffer method as it's only called from AbstractSession. encode, while the preProcessEncodeBuffer is defined in the SessionHelper and overriden in the AbstractSession. This looks rather complex instead of simply adding the few needed lines in the existing encode method (efdb7c3#diff-916a03c44b5846431681a4411891d952R843-R849). True, but it was the only way that I could come up with - IMO `encode` already does so much (lots of code for one method) so I thought it would make sense to split it rather than add to it. Anyway, like I said it opens up the door for future fixes/extension - e.g., perhaps one of the derived classes from `AbsractSession` needs something else. >> Anyway, if you really wanted something simple, we could go for gnodet@cdefec7 which is much simpler ;-) True, but IMO this fix while more complex feels more robust. Any objections to merging it ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
