gnodet commented on issue #115: Add timeout with Duration and apply larger timeouts to tests that oft… URL: https://github.com/apache/mina-sshd/pull/115#issuecomment-592007424 That's right, but CI systems are usually slower than our development laptops. It does seem to help passing tests however. But I'm not sure to understand the argument, the problem would only happen while developing and if some tests are wrong, right ? That should not be the usual case and test cases usually fail fast for other problems. But you're right, in theory we could raise the build time _when something is wrong_. Le jeu. 27 févr. 2020 à 15:53, Lyor Goldstein <[email protected]> a écrit : > The goal is to raise the timeout when possible to see if the CI is more > green. > > Let's be careful not to raise it too much or failing tests will slow the > tests as a whole - if each test is allowed ~30 sec. to fail and we have > 100's of tests we might get a total build time of *hours*. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/mina-sshd/pull/115?email_source=notifications&email_token=AAAUQNVI6U6A7I3SGFF7RKLRE7HWPA5CNFSM4K433GGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENEUPNQ#issuecomment-592005046>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAUQNXDIHJBG5Z4PF3PILTRE7HWPANCNFSM4K433GGA> > . > -- ----------------------- Guillaume Nodet ------------------------ Red Hat, Open Source Integration Email: [email protected] Web: http://fusesource.com Blog: http://gnodet.blogspot.com/
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
