lgoldstein commented on issue #95: SSHD-901 Provide 'wantReply' option for client keep-alive heartbeat global request URL: https://github.com/apache/mina-sshd/pull/95#issuecomment-609041673 >> to close any dangling client sessions from server due to network issues Please bear in mind that this mechanism is a **client side** one - i.e., it is used by the client in order to detect a non-responsive server sooner than the regular TCP/IP timeout would. AFAIK there is no server side mechanism to detect "dangling" client sessions. We do have an idle-timeout mechanism that closes a session if there is no traffic for the specified amount of time (current default=10 minutes). The purpose of the `keepalive@` mechanism (besides early detection) is also to generate some traffic so that the client does not time out if there is no traffic. By activating the `wantReply` option (default=disabled) we try to ensure that the server does not time out due to no traffic. Therefore, the `keepalive@` mechanism is not likely to detect "dangling clients" on the server side. See https://github.com/apache/mina-sshd/blob/master/docs/client-setup.md#keeping-the-session-alive-while-no-traffic on client heartbeat details, and the code for `SessionHelper#getIdleTimeout` There is a way to do this on the server side but it is rather **non-standard** (which we support) and it involves sending {{SSH_MSG_IGNORE}} messages from the server to the client thus maintaining some traffic on the session as well as detecting "dangling clients". See `setSessionHeartbeat` API with a {{HeartbeatType}} of `IGNORE`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
