lgoldstein commented on issue #119: Add support for openssh host key 
certificates
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-615619181
 
 
   >> OpenSSH actually does a fallback to the plain host key, maybe we should 
do the same instead of aborting the connection if the certificate is invalid. 
Makes especially sense if the certificate is expired, you still want to be able 
to connect..
   
   I can live with that - just a suggestion - you can make the behavior 
configurable via a property that you can retrieve from the session (default can 
be whatever you  decide).
   
   >> I am currently on the unit tests, having some issues with RSA key 
mismatch exception... 512 vs 256 .. need to investigate further...
   
   Great -  will wait for you to let me know when you feel the code is ready 
for more review and merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to