gnodet commented on issue #121: Autoformat source code URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616168471 > > > Not sure what you refer to exactly here. I think the formatting takes into accounts all style related rules, spaces, braces, indentation, etc... You may have seen the changes in indentation, but that only means all other are the same. > > Checkstyle also has metrics - such as max. lines per method, max. lines per file, max. parameters per method, enforce `@Override` annotation, rules for variables naming, visibility fields orderings, etc., > etc., etc... that are not a matter of indentation. How can we keep enforcing them (BTW, they do not have PMD equivalents) Ok, we can easily keep those, I don't have any problems with that. The ones that are problematic to me are mostly the styling ones. I'll add a commit to bring them back.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
