lgoldstein commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412178637
##########
File path:
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java
##########
@@ -954,7 +954,9 @@ protected IoWriteFuture doWritePacket(Buffer buffer) throws
IOException {
synchronized (encodeLock) {
Buffer packet = resolveOutputPacket(buffer);
IoSession networkSession = getIoSession();
- return networkSession.writePacket(packet);
+ IoWriteFuture future = networkSession.writePacket(packet);
+ buffer.rpos(buffer.wpos());
+ return future;
Review comment:
>> So while the packet is yet to be written, the buffer won't be used
anymore and is consumed at the time the buffer.rpos(buffer.wpos()) is called.
That was not what I meant - `networkSession#writePacket` might be
asynchronous - i.e., posts the buffer for writing and returns immediately - so
when it attempt to access `rpos` it might use the wrong one since we override
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
