David Ostrovsky created SSHD-997:
------------------------------------

             Summary: Replace EdDSA-Java library with new ed25519-elisabeth 
implementation
                 Key: SSHD-997
                 URL: https://issues.apache.org/jira/browse/SSHD-997
             Project: MINA SSHD
          Issue Type: New Feature
    Affects Versions: 2.4.0
            Reporter: David Ostrovsky


Recent addition to the SSHD library revealed issues with seed attribute in 
EdDSA-Java library:

{code:java}
+    private boolean compare(KeyPair a, KeyPair b) {
+        if ("EDDSA".equals(data.algorithm)) {
+            // Bug in net.i2p.crypto.eddsa and in sshd? Both also compare the
+            // seed of the private key, but for a generated key, this is some
+            // random value, while it is all zeroes for a key read from a file.
+            return KeyUtils.compareKeys(a.getPublic(), b.getPublic())
+                    && Objects.equals(((EdDSAKey) a.getPrivate()).getParams(),
+                            ((EdDSAKey) b.getPrivate()).getParams());
+        }
{code}

The corresponding issue: [1] upstream pointing to the new library: 

[1] https://github.com/str4d/ed25519-java/issues/30#issuecomment-573389252
[2] https://github.com/cryptography-cafe/ed25519-elisabeth



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to