jvz commented on a change in pull request #132: URL: https://github.com/apache/mina-sshd/pull/132#discussion_r428112293
########## File path: sshd-common/src/main/java/org/apache/sshd/common/cipher/BuiltinCiphers.java ########## @@ -46,39 +46,48 @@ * @author <a href="mailto:dev@mina.apache.org";>Apache MINA SSHD Project</a> */ public enum BuiltinCiphers implements CipherFactory { - none(Constants.NONE, 0, 0, "None", 0, "None", 0) { + none(Constants.NONE, 0, 0, 0, "None", 0, "None", 0) { @Override public Cipher create() { return new CipherNone(); } }, - aes128cbc(Constants.AES128_CBC, 16, 16, "AES", 128, "AES/CBC/NoPadding", 16), - aes128ctr(Constants.AES128_CTR, 16, 16, "AES", 128, "AES/CTR/NoPadding", 16), - aes192cbc(Constants.AES192_CBC, 16, 24, "AES", 192, "AES/CBC/NoPadding", 16), - aes192ctr(Constants.AES192_CTR, 16, 24, "AES", 192, "AES/CTR/NoPadding", 16), - aes256cbc(Constants.AES256_CBC, 16, 32, "AES", 256, "AES/CBC/NoPadding", 16), - aes256ctr(Constants.AES256_CTR, 16, 32, "AES", 256, "AES/CTR/NoPadding", 16), - arcfour128(Constants.ARCFOUR128, 8, 16, "ARCFOUR", 128, "RC4", 16) { + aes128cbc(Constants.AES128_CBC, 16, 0, 16, "AES", 128, "AES/CBC/NoPadding", 16), + aes128ctr(Constants.AES128_CTR, 16, 0, 16, "AES", 128, "AES/CTR/NoPadding", 16), + aes128gcm(Constants.AES128_GCM, 12, 16, 16, "AES", 128, "AES/GCM/NoPadding", 16) { + @Override + public Cipher create() { + return new BaseGCMCipher( + getIVSize(), getKdfSize(), getAlgorithm(), getKeySize(), getTransformation(), getCipherBlockSize(), getAuthenticationTagSize()); + } + }, + // TODO: aes256gcm Review comment: SSH doesn't seem to support that: https://github.com/openbsd/src/blob/master/usr.bin/ssh/cipher.c ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
