[
https://issues.apache.org/jira/browse/SSHD-997?focusedWorklogId=436391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-436391
]
ASF GitHub Bot logged work on SSHD-997:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/20 05:05
Start Date: 22/May/20 05:05
Worklog Time Spent: 10m
Work Description: lgoldstein commented on pull request #135:
URL: https://github.com/apache/mina-sshd/pull/135#issuecomment-632483018
Thanks for the patch - merged in - can close this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 436391)
Time Spent: 20m (was: 10m)
> Replace EdDSA-Java library with new ed25519-elisabeth implementation
> --------------------------------------------------------------------
>
> Key: SSHD-997
> URL: https://issues.apache.org/jira/browse/SSHD-997
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: David Ostrovsky
> Assignee: Lyor Goldstein
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Recent addition to the SSHD library revealed issues with seed attribute in
> EdDSA-Java library:
> {code:java}
> + private boolean compare(KeyPair a, KeyPair b) {
> + if ("EDDSA".equals(data.algorithm)) {
> + // Bug in net.i2p.crypto.eddsa and in sshd? Both also compare the
> + // seed of the private key, but for a generated key, this is some
> + // random value, while it is all zeroes for a key read from a
> file.
> + return KeyUtils.compareKeys(a.getPublic(), b.getPublic())
> + && Objects.equals(((EdDSAKey)
> a.getPrivate()).getParams(),
> + ((EdDSAKey) b.getPrivate()).getParams());
> + }
> {code}
> The corresponding issue: [1] upstream pointing to the new library:
> [1] https://github.com/str4d/ed25519-java/issues/30#issuecomment-573389252
> [2] https://github.com/cryptography-cafe/ed25519-elisabeth
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
