lgoldstein commented on pull request #132: URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-633253726
>> The tests all pass on my machine. I'm not sure what's going on with the failing one on here. That's OK - if you feel the code is ready as far as you are concerned, let me know. Once I have examined it and successfully ran a full `mvn clean install` on my machine I am willing to merge it. Our Travis builds are not yet 100% stable so if they fail but the tests succeed on my machine I usually consider the code safe to merge. That being said, please run some tests with OpenSSH clients/servers that support these ciphers as well as some popular applications such as _Putty, WinSCP, FileZilla_ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
