[
https://issues.apache.org/jira/browse/SSHD-750?focusedWorklogId=437346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437346
]
ASF GitHub Bot logged work on SSHD-750:
---------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 03:38
Start Date: 27/May/20 03:38
Worklog Time Spent: 10m
Work Description: gnodet closed pull request #31:
URL: https://github.com/apache/mina-sshd/pull/31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 437346)
Remaining Estimate: 0h
Time Spent: 10m
> Accept SSH clients advertising vesion 1.99
> ------------------------------------------
>
> Key: SSHD-750
> URL: https://issues.apache.org/jira/browse/SSHD-750
> Project: MINA SSHD
> Issue Type: New Feature
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Scott Meeuwsen
> Assignee: Lyor Goldstein
> Priority: Minor
> Fix For: 1.6.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I debated listing this as a bug, given clients advertising 1.99 are SSH 2.0
> clients and are being rejected, I believe, somewhat accidentally. However, on
> further research I see that the RFC doesn't really cover this situation (only
> the opposite: a server advertising 1.99 to a 2.0 client). Ultimately, I do
> think this should be supported given:
> 1) the server/client will still talk 2.0, nobody is suggesting adding a mode
> whereby they talk 1.x, so there shouldn't be a security issue here
> 2) MINA SSH client already supports it (inverse situation), so this creates
> alignment within the code between client/server capabilities
> 3) OpenSSH server supports it (not that everybody has to copy OpenSSH
> behavior, but it is certainly a widely supported implementation to look for
> advice on how to behave)
> 4) the patch is a one liner, easy to understand, and was easily tested (aka
> it works)
> Github pull request:
> https://github.com/apache/mina-sshd/pull/31
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
