[
https://issues.apache.org/jira/browse/SSHD-1003?focusedWorklogId=441160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441160
]
ASF GitHub Bot logged work on SSHD-1003:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/20 08:18
Start Date: 04/Jun/20 08:18
Worklog Time Spent: 10m
Work Description: gnodet commented on a change in pull request #137:
URL: https://github.com/apache/mina-sshd/pull/137#discussion_r435075028
##########
File path:
sshd-core/src/main/java/org/apache/sshd/common/io/nio2/Nio2Session.java
##########
@@ -368,7 +368,6 @@ protected void handleReadCycleCompletion(
log.debug("handleReadCycleCompletion({}) Socket has been
disconnected (result={}), closing IoSession now",
this, result);
}
- close(true);
Review comment:
This suppression seems to remove a bunch of problems with the channel
being closed way too early. The `-1` result indicates an EOF, but not an
error, so closing the session is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 441160)
Time Spent: 20m (was: 10m)
> Use asynchronous streams when forwarding ports
> ----------------------------------------------
>
> Key: SSHD-1003
> URL: https://issues.apache.org/jira/browse/SSHD-1003
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
