[
https://issues.apache.org/jira/browse/SSHD-1038?focusedWorklogId=461871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461871
]
ASF GitHub Bot logged work on SSHD-1038:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/20 06:31
Start Date: 22/Jul/20 06:31
Worklog Time Spent: 10m
Work Description: lgoldstein commented on pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144#issuecomment-662269701
>> I fail to clearly understand where the separation has been drawn between
sshd-core and sshd-common.
I agree - it was an ongoing attempt to preserve package names and just move
classes. The basic criterion I used is `sshd-common` tests do not require an
active client/server whereas `sshd-core` ones do.
>> We could eventually split between o.a.sshd.common, o.a.sshd.client,
o.a.sshd.server and o.a.sshd.agent into 4 maven modules (common, client,
server, agent). That should allow to move the OSGi metadata into these modules
and get rid of sshd-osgi.
That would be a good solution though I fear the separation is not quite
clean-cut since some classes are required by both client and server - so we
might need 5 modules: `sshd-common` for all sort of utilities, `sshd-core` for
classes that are required by both client and server and then 'client, server,
agent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 461871)
Time Spent: 1h 10m (was: 1h)
> Refactor packages from a module into a cleaner hierarchy
> --------------------------------------------------------
>
> Key: SSHD-1038
> URL: https://issues.apache.org/jira/browse/SSHD-1038
> Project: MINA SSHD
> Issue Type: New Feature
> Affects Versions: 2.6.0
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I think it would better to refactor some of the packages into a clean
> hierarchy.
> For example:
> * org.apache.sshd.client.scp -> org.apache.sshd.scp.client
> * org.apache.sshd.common.scp -> org.apache.sshd.scp.common
> The idea is that modules such as sshd-scp, sshd-sftp... have a single root
> package {{org.apache.sshd.(scp|sftp)}} and subpackages for {{common}},
> {{client}}, {{server}}...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
